Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toughen rough linting #415

Merged
merged 8 commits into from Feb 6, 2024
Merged

Toughen rough linting #415

merged 8 commits into from Feb 6, 2024

Conversation

tony
Copy link
Owner

@tony tony commented Feb 6, 2024

@tony
ruff . --select COM --fix
a5b40dd
@tony
ruff format (after adding flake8-commas)
a977d8c
@tony
pyproject(ruff): Add flake8-commas, ignore COM812 for ruff format
10c9b04 
See also:
- https://docs.astral.sh/ruff/rules/#flake8-commas-com
- https://pypi.org/project/flake8-commas/

Ignoring COM812:
- https://docs.astral.sh/ruff/formatter/#conflicting-lint-rules
- https://docs.astral.sh/ruff/rules/missing-trailing-comma/
@tony
pyproject(ruff): flake8-builtins
3f217fc 
See also:
- https://docs.astral.sh/ruff/rules/#flake8-builtins-a
- https://pypi.org/project/flake8-builtins/
@tony
fix!: Fix shadowing of python builtins
db7bbfc 
docs/conf.py:62:1: A001 Variable `copyright` is shadowing a Python builtin
Found 1 error.
@tony
pyproject(ruff): Add flake8-errmsg
42e2600 
See also:
- https://docs.astral.sh/ruff/rules/#flake8-errmsg-em
- https://pypi.org/project/flake8-errmsg/
@tony
fix: direct .format() usage in exception message
5c0b34f 
src/django_docutils/lib/metadata/extract.py:69:21: EM102 Exception must not use an f-string literal, assign to variable first
Found 1 error.
@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2f92fff) 0.00% compared to head (5c0b34f) 74.17%.

Files Patch % Lines
src/django_docutils/lib/metadata/extract.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #415       +/-   ##
===========================================
+ Coverage        0   74.17%   +74.17%     
===========================================
  Files           0       43       +43     
  Lines           0     1146     +1146     
===========================================
+ Hits            0      850      +850     
- Misses          0      296      +296

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tony tony merged commit 5c1d856 into master Feb 6, 2024
4 checks passed
@tony tony deleted the ruff-toughen branch February 6, 2024 16:40
tony added a commit that referenced this pull request Feb 6, 2024
@tony
Tag v0.23.0 (linting updates from #415)
bd47aea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tony