Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new xcode project for static lib #38

Closed
wants to merge 7 commits into from

Conversation

pablonosh
Copy link
Collaborator

I've tested this on Carthage, but should also be tested on cocoapods

@tonyarnold
Copy link
Owner

Thanks for this @pablonosh.

Sorry, but I'm not clear on exactly what you've changed? It looks like you've separated the tests into their own scheme, rather than as testable components of the framework scheme, but given the size of the changes there's a lot to dig through here.

Can you give me a quick rundown of what was causing the issues for Carthage's static linking script, and what your changes do to fix that? Thanks!

@pablonosh
Copy link
Collaborator Author

pablonosh commented Jul 2, 2018 via email

@tonyarnold
Copy link
Owner

Thanks @pablonosh - I'll try to work out what specifically has been changed, and just change that in the original project.

@pablonosh
Copy link
Collaborator Author

Hi, any luck with this? It'd be great to get this working for my project from develop.

Ta

@tonyarnold
Copy link
Owner

@pablonosh sorry, I've not had time this past couple of months. I'll try to make some time this evening.

@tonyarnold
Copy link
Owner

No wonder we couldn’t get this working - Carthage’s static framework instructions don’t work anymore. There’s a long discussion here, but essentially the recommendation is to create a script that changes the Mach-O type of the project to “static library”, and then pop this in your process:

$ carthage update --no-build
$ ./myScriptThatChangesTypes
$ carthage build

I’m going to close out this PR, and the original report. I’ll have a think about how I could include this script in this repo for you to use.

@pablonosh
Copy link
Collaborator Author

Ace, I'm having trouble finding myScriptThatChangesTypes - any pointers?

@tonyarnold
Copy link
Owner

Ah, I figured you'd have to write it 😀👍

You need to set the build setting MACH_O_TYPE = staticlib.

@pablonosh
Copy link
Collaborator Author

Ah ha - Carthage/Carthage#2575 (comment)

@pablonosh
Copy link
Collaborator Author

Thanks for all the help tony, this is now working for me cleanly. ta

@tonyarnold
Copy link
Owner

That's great to hear - thanks for linking me to the script. I'm not sure we need to include it in Differ's repository, but I'm happy to consider it if you think it's useful. Sounds like it's more of a "your project" kind of thing, though.

I also think we'll see this functionality come with updates to SPM/Xcode in the coming year.

@tonyarnold tonyarnold deleted the feature/new-xcode-project-for-static-lib branch September 28, 2018 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants