-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/new xcode project for static lib #38
Conversation
Thanks for this @pablonosh. Sorry, but I'm not clear on exactly what you've changed? It looks like you've separated the tests into their own scheme, rather than as testable components of the framework scheme, but given the size of the changes there's a lot to dig through here. Can you give me a quick rundown of what was causing the issues for Carthage's static linking script, and what your changes do to fix that? Thanks! |
Oh I didn’t mean to change any structure. So probably best to revert the tests.
I rebuilt the xcode project for the latest xcode 9.4, so that it rebuilds with carthage static frameworks. The xcode project was made in xcode 3.2 so I think some setting needed for static frameworks which didn’t exist in 3.2 as it’s a new feature.
If you compare the project build settings and structure it should be identical. But Xcode sometimes is flaky like this.
Happy to help in anyway i can
Ta
…________________________________
From: Tony Arnold <notifications@github.com>
Sent: Saturday, June 30, 2018 11:33:28 AM
To: tonyarnold/Differ
Cc: Peter Nash; Mention
Subject: Re: [tonyarnold/Differ] Feature/new xcode project for static lib (#38)
Thanks for this @pablonosh<https://github.com/pablonosh>.
Sorry, but I'm not clear on exactly what you've changed? It looks like you've separated the tests into their own scheme, rather than as testable components of the framework scheme, but given the size of the changes there's a lot to dig through here.
Can you give me a quick rundown of what was causing the issues for Carthage's static linking script, and what your changes do to fix that? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#38 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAdWHP2lsjI-PyPP_t25ABxbV1G_qf5Yks5uB1P4gaJpZM4U6QnB>.
This message is private and confidential and may also be legally privileged. If you have received this message in error, please email it back to the sender and immediately permanently delete it from your computer system. Please do not read, print, re-transmit, store or act in reliance on it or any attachments. British Airways may monitor email traffic data and also the content of emails, where permitted by law, for the purposes of security and staff training and in order to prevent or detect unauthorised use of the British Airways email system. Virus checking of emails (including attachments) is the responsibility of the recipient. British Airways Plc is a public limited company registered in England and Wales. Registered number: 1777777. Registered office: Waterside, PO Box 365, Harmondsworth, West Drayton, Middlesex, England, UB7 0GB. Additional terms and conditions are available on our website: www.ba.com
|
Thanks @pablonosh - I'll try to work out what specifically has been changed, and just change that in the original project. |
Hi, any luck with this? It'd be great to get this working for my project from develop. Ta |
@pablonosh sorry, I've not had time this past couple of months. I'll try to make some time this evening. |
No wonder we couldn’t get this working - Carthage’s static framework instructions don’t work anymore. There’s a long discussion here, but essentially the recommendation is to create a script that changes the Mach-O type of the project to “static library”, and then pop this in your process:
I’m going to close out this PR, and the original report. I’ll have a think about how I could include this script in this repo for you to use. |
Ace, I'm having trouble finding myScriptThatChangesTypes - any pointers? |
Ah, I figured you'd have to write it 😀👍 You need to set the build setting |
Ah ha - Carthage/Carthage#2575 (comment) |
Thanks for all the help tony, this is now working for me cleanly. ta |
That's great to hear - thanks for linking me to the script. I'm not sure we need to include it in Differ's repository, but I'm happy to consider it if you think it's useful. Sounds like it's more of a "your project" kind of thing, though. I also think we'll see this functionality come with updates to SPM/Xcode in the coming year. |
I've tested this on Carthage, but should also be tested on cocoapods