Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NSTableView animations #70

Merged
merged 6 commits into from Jun 16, 2020
Merged

Fix NSTableView animations #70

merged 6 commits into from Jun 16, 2020

Commits on May 28, 2020

  1. Fix wrong NSTableView move animations by using ExtendedPatch sequence… 

    … instead of Diff
    @hannesoid
    hannesoid committed May 28, 2020
    Configuration menu
    Copy the full SHA
    8f57c69 View commit details
    Browse the repository at this point in the history

  2. Prevent unwanted height processing: no UITableView.beginUpdates/endUp… 

    …dates with empty diff
    @hannesoid
    hannesoid committed May 28, 2020
    Configuration menu
    Copy the full SHA
    1c08885 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2020

  1. Revert "Prevent unwanted height processing: no UITableView.beginUpdat… 

    …es/endUpdates with empty diff"

This reverts commit 1c08885.
    @hannesoid
    hannesoid committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    888cd41 View commit details
    Browse the repository at this point in the history

  2. Remove skipping of beginUpdates/endUpdates when applying patches to N… 

    …STableView - leave this case to caller
    @hannesoid
    hannesoid committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    0f7490d View commit details
    Browse the repository at this point in the history

  3. Revert removal of default param on deprecated NSTableView extension m… 

    …ethod
    @hannesoid
    hannesoid committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    8c99037 View commit details
    Browse the repository at this point in the history

  4. Apply Review comments for NSTableView diffing 

    - Remove CustomEquatable in favor of diff.patch
- re-add deprecated indexPathTransform variants
- add lost default argument for deprecated diff apply method
- add // MARKS
    @hannesoid
    hannesoid committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    6636cd5 View commit details
    Browse the repository at this point in the history