add support for sharing floats

tonybaloney · Oct 29, 2023 · 9a6041b · 9a6041b
1 parent 66bea25
commit 9a6041b
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 1 deletion.
diff --git a/Lib/test/test__xxsubinterpreters.py b/Lib/test/test__xxsubinterpreters.py
@@ -102,6 +102,7 @@ def test_default_shareables(self):
                 'spam',
                 10,
                 -10,
+                100.0,
                 ]
         for obj in shareables:
             with self.subTest(obj):
@@ -129,7 +130,6 @@ class SubBytes(bytes):
                 object,
                 object(),
                 Exception(),
-                100.0,
                 # user-defined types and objects
                 Cheese,
                 Cheese('Wensleydale'),
@@ -189,6 +189,9 @@ def test_non_shareable_int(self):
                 with self.assertRaises(OverflowError):
                     _testcapi.get_crossinterp_data(i)
 
+    def test_float(self):
+        self._assert_values([0.0, 1.1, -1.0, 0.12345678, -0.12345678])
+
 
 class ModuleTests(TestBase):
 

diff --git a/Misc/NEWS.d/next/Core and Builtins/2023-10-29-12-33-33.gh-issue-111438.bHTLLl.rst b/Misc/NEWS.d/next/Core and Builtins/2023-10-29-12-33-33.gh-issue-111438.bHTLLl.rst
@@ -0,0 +1 @@
+Added support for sharing of float type with interpreters API.
diff --git a/Python/pystate.c b/Python/pystate.c
@@ -2933,6 +2933,29 @@ _str_shared(PyThreadState *tstate, PyObject *obj,
     return 0;
 }
 
+static PyObject *
+_new_float_object(_PyCrossInterpreterData *data)
+{
+    double * value_ptr = data->data;
+    return PyFloat_FromDouble(*value_ptr);
+}
+
+static int
+_float_shared(PyThreadState *tstate, PyObject *obj,
+             _PyCrossInterpreterData *data)
+{
+    if (_PyCrossInterpreterData_InitWithSize(
+            data, tstate->interp, sizeof(double), obj,
+            _new_float_object
+            ) < 0)
+    {
+        return -1;
+    }
+    double * shared = (double*)data->data;
+    *shared =  PyFloat_AsDouble(obj);
+    return 0;
+}
+
 static PyObject *
 _new_long_object(_PyCrossInterpreterData *data)
 {
@@ -2999,6 +3022,11 @@ _register_builtins_for_crossinterpreter_data(struct _xidregistry *xidregistry)
     if (_xidregistry_add_type(xidregistry, &PyUnicode_Type, _str_shared) != 0) {
         Py_FatalError("could not register str for cross-interpreter sharing");
     }
+
+    // float
+    if (_xidregistry_add_type(xidregistry, &PyFloat_Type, _float_shared) != 0) {
+        Py_FatalError("could not register float for cross-interpreter sharing");
+    }
 }