Skip to content
This repository has been archived by the owner on May 4, 2020. It is now read-only.

[WIP] Testing python 3 issue #12

Closed
wants to merge 14 commits into from
Closed

Conversation

tonybaloney
Copy link
Owner

@tonybaloney tonybaloney commented Dec 23, 2017

Try and recreate the Python 3 crash in a test.

Summary of the problem:

  • Occurs when Python 3 is the runtime executing the retox module
  • Occurs in the refresh method of asciimatics
  • Does not happen in py27,py36 environments, only on pylint or lint.
  • Normally happens when tests are re-run and related to the finishing of jobs

@codecov-io
Copy link

codecov-io commented Dec 23, 2017

Codecov Report

Merging #12 into master will increase coverage by 49.8%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   30.33%   80.14%   +49.8%     
==========================================
  Files          10       10              
  Lines         422      428       +6     
==========================================
+ Hits          128      343     +215     
+ Misses        294       85     -209
Impacted Files Coverage Δ
retox/service.py 82.52% <100%> (+60.95%) ⬆️
retox/__init__.py 100% <100%> (ø) ⬆️
retox/__main__.py 56.47% <50%> (+25.22%) ⬆️
retox/log.py 76.31% <0%> (+7.89%) ⬆️
retox/reporter.py 88.13% <0%> (+55.93%) ⬆️
retox/proclimit.py 57.14% <0%> (+57.14%) ⬆️
retox/ui.py 93.16% <0%> (+70.08%) ⬆️
retox/exclude.py 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eaef48...74f2456. Read the comment docs.

@tonybaloney
Copy link
Owner Author

Here is the stack trace of the issue

!!!!!! Process crash !!!!!!!
Traceback (most recent call last):
  File "/Users/anthonyshaw/repo/retox-3/retox/log.py", line 12, in wrapper
    return f(*args, **kwds)
  File "/Users/anthonyshaw/repo/retox-3/retox/reporter.py", line 78, in logaction_finish
    self.env_frames[action.venv.name].stop(action.activity, action)
  File "/Users/anthonyshaw/repo/retox-3/retox/ui.py", line 259, in stop
    self.refresh()
  File "/Users/anthonyshaw/repo/retox-3/retox/ui.py", line 59, in refresh
    self._screen.refresh()
  File "/Users/anthonyshaw/repo/retox-3/lib/python3.6/site-packages/asciimatics/screen.py", line 2126, in refresh
    super(_CursesScreen, self).refresh()
  File "/Users/anthonyshaw/repo/retox-3/lib/python3.6/site-packages/asciimatics/screen.py", line 1217, in refresh
    self._print_at(new_cell[0], x, y, new_cell[4])
  File "/Users/anthonyshaw/repo/retox-3/lib/python3.6/site-packages/asciimatics/screen.py", line 2256, in _print_at
    self._safe_write(cursor + text)
  File "/Users/anthonyshaw/repo/retox-3/lib/python3.6/site-packages/asciimatics/screen.py", line 2084, in _safe_write
    sys.stdout.write(msg)
  File "/Users/anthonyshaw/repo/retox-3/bin/../lib/python3.6/codecs.py", line 377, in write
    self.stream.write(data)
  File "/Users/anthonyshaw/repo/retox-3/bin/../lib/python3.6/codecs.py", line 376, in write
    data, consumed = self.encode(object, self.errors)
TypeError: utf_8_encode() argument 1 must be str, not bytes

@tonybaloney tonybaloney mentioned this pull request Dec 23, 2017
@bstpierre bstpierre mentioned this pull request Dec 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants