Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rat pet #332

Merged
merged 15 commits into from
Feb 9, 2023
Merged

Rat pet #332

merged 15 commits into from
Feb 9, 2023

Conversation

piotrszleg
Copy link
Contributor

@piotrszleg piotrszleg commented Nov 28, 2022

Adds rat as a pet type.

Rats roam around and jump when hovered over.

They can chase a ball, but don't climb on walls.

There are three rat colors

  • gray
  • white with red eyes
  • brown (mixed brown head and white body)

gray rat

white rat

brown rat

editor screenshot

Related to issue #28

@piotrszleg piotrszleg changed the title Rat pet [WIP] Rat pet Nov 29, 2022
@piotrszleg
Copy link
Contributor Author

run

@piotrszleg piotrszleg changed the title [WIP] Rat pet Rat pet Dec 20, 2022
@piotrszleg
Copy link
Contributor Author

piotrszleg commented Dec 20, 2022

I think that everything is finished, please let me know if I need to correct anything 🐀

@piotrszleg
Copy link
Contributor Author

@tonybaloney maybe you missed the notification about this pull request changing status from draft, so I added a mention.

@tonybaloney
Copy link
Owner

Thanks. I'm on holiday for a few weeks. I'll take a look when I'm back

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Merging #332 (db3549b) into master (381735e) will increase coverage by 0.18%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   16.81%   17.00%   +0.18%     
==========================================
  Files          20       21       +1     
  Lines        1136     1147      +11     
  Branches      154      154              
==========================================
+ Hits          191      195       +4     
- Misses        936      946      +10     
+ Partials        9        6       -3     
Impacted Files Coverage Δ
src/common/types.ts 71.42% <ø> (ø)
src/panel/pets.ts 20.58% <33.33%> (+0.38%) ⬆️
src/panel/pets/rat.ts 50.00% <50.00%> (ø)
src/extension/extension.ts 21.06% <0.00%> (-0.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@piotrszleg
Copy link
Contributor Author

I fixed an error in the merged package.json that caused the pipelines to fail,

@tonybaloney
Copy link
Owner

Love it. 👍🏻

@tonybaloney tonybaloney merged commit 9cfa0c8 into tonybaloney:master Feb 9, 2023
tonybaloney added a commit that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants