Add step to run lint before raising a PR #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR check fails for lint issues. It will be better to fix them beforehand.
|
We could also use a Pull Request template. Please let me know if that sounds better, will create a template and raise a PR. |
tonybaloney
approved these changes
Dec 3, 2022
|
Thanks, I was about to leave a comment asking you to lint the other PR. WRT to pull request templates, I have never found them helpful as a contributor and nobody seems to fill them in as a maintainer. |
tonybaloney
added a commit
that referenced
this pull request
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR check fails for lint issues. It will be better to fix them beforehand.