Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Gifs Filename Linter #366

Merged
merged 4 commits into from
Jan 15, 2023
Merged

Verify Gifs Filename Linter #366

merged 4 commits into from
Jan 15, 2023

Conversation

Harry-Hopkinson
Copy link
Contributor

A linter that runs a test which tests if gifs follow the pattern. For #363

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2023

Codecov Report

Merging #366 (3c281cc) into master (97346ff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #366   +/-   ##
=======================================
  Coverage   16.91%   16.91%           
=======================================
  Files          20       20           
  Lines        1129     1129           
  Branches      152      152           
=======================================
  Hits          191      191           
  Misses        929      929           
  Partials        9        9           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Harry-Hopkinson
Copy link
Contributor Author

@tonybaloney this PR should be ready. 😃

Copy link
Owner

@tonybaloney tonybaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check is running backward. instead of looking at each file and checking if it matches the pattern, it should look at every pet and work out what GIFs should exist and then check they do.

It should go to

  • Get all pets
  • For each pet get all colors
  • For each pet get all possible states by traversing tree
    Then check every file exists.

Thanks

@Harry-Hopkinson
Copy link
Contributor Author

I have not done anything to the main-bundle but it has changed in the git diff.

@tonybaloney
Copy link
Owner

Thanks, ideally it should import those types and do it dynamically but we can tackle that later

@tonybaloney tonybaloney merged commit 9f9f701 into tonybaloney:master Jan 15, 2023
@Harry-Hopkinson Harry-Hopkinson deleted the Verify-Gifs-Filename-Linter branch January 15, 2023 21:18
tonybaloney added a commit that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants