Add Rocky the rock #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonybaloney
reviewed
Dec 8, 2021
| [2, 'The Rock'], | ||
| [3, 'Quartzy'], | ||
| [4, 'Rocky I'], | ||
| [5, 'Rocky II'], |
There was a problem hiding this comment.
This was going to be my only comment on the code-review. Great minds...
|
Love this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rocky doesn't move and doesn't run & catch a ball. The due to lack of movement I had to make some changes how
nextFrameis handled. This was done purely on movement but now a timeout is added, similar to theAbstractStaticStateimplementation. If you have other ideas on how to do this better please do let me know. I also prevent the image from changing direction since it doesn't move. I've testing this locally and it seems to work as intended. No side effects to the existing pets. Please do have a good look yourself since the change was bigger than I expected.Fixes #42