Do not spawn a pet with a broken image if you cancel spawning a pet. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@tonybaloney this PR should be ready for review |
|
Thanks @Harry-Hopkinson |
tonybaloney
added a commit
that referenced
this pull request
Feb 26, 2023
Do not spawn a pet with a broken image if you cancel spawning a pet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before if you are in the process of spawning a pet and you cancel the operation with escape or close the spawn pet tab. A broke image is shown like below.
However with this new change, if the process of creating a pet is cancelled, an image is not displayed and a vscode.window.showErrorMessage is displayed. Like so...
