Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cache_path option to wily.cfg #123

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

skarzi
Copy link
Contributor

@skarzi skarzi commented Sep 9, 2020

Closes: #117

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2020

Codecov Report

Merging #123 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   97.98%   97.99%           
=======================================
  Files          23       23           
  Lines        1143     1145    +2     
=======================================
+ Hits         1120     1122    +2     
  Misses         23       23           
Impacted Files Coverage Δ
src/wily/config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b2139b...c87aa8f. Read the comment docs.

@skarzi
Copy link
Contributor Author

skarzi commented Sep 9, 2020

We can also discuss config loading and processing more deeply, so it can be refactored a bit to make adding new options easier and safer, but also produce more meaningful messages for invalid option's values

@tonybaloney
Copy link
Owner

Brilliant! thanks for the contribution. Sorry I missed this earlier

@tonybaloney tonybaloney merged commit d749f67 into tonybaloney:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add possibility to load cache_path option from wily.cfg
3 participants