Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade plotly from 4.x to 5.x #167

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Upgrade plotly from 4.x to 5.x #167

merged 2 commits into from
Oct 20, 2022

Conversation

anderso
Copy link
Contributor

@anderso anderso commented Oct 17, 2022

I could not use Wily in my project that uses a 5.x version of Plotly because dependencies could not be resolved. This updates the Plotly dependency to be compatible with 5.x. Tests are passing and I have tested it on my project successfully with 5.10.0 so my guess is this is safe. Here's the relevant section of the release notes:

https://community.plotly.com/t/introducing-plotly-py-5-0-0-a-new-federated-jupyter-extension-icicle-charts-and-bar-chart-patterns/54039#warning-backwards-incompatible-changes-2

Our commitment to semantic versioning requires us to make this release a major version bump (up from 4.14.3) because we are upgrading to version 2.1 of the underlying Plotly.js library, which makes some backwards-incompatible changes to older and deprecated features (see below), but we see this as a low-risk maintenance release and we expect that the vast majority of users should plan to upgrade without fearing significant issues!

@tonybaloney
Copy link
Owner

Thanks, I'll merge this in once the tests have all passed

@anderso
Copy link
Contributor Author

anderso commented Oct 19, 2022

There seems to be something unrelated breaking the Window builds, probably related to a failing pip upgrade:

ERROR: To modify pip, please run the following command:
C:\hostedtoolcache\windows\Python\3.10.7\x64\python.exe -m pip install --upgrade pip wheel flit

Notice: A new release of pip available: 22.2.2 -> 22.3
Notice: To update, run: python.exe -m pip install --upgrade pip

@codecov-commenter
Copy link

Codecov Report

Merging #167 (3d3c789) into master (4f524c2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files          23       23           
  Lines        1216     1216           
  Branches      273      273           
=======================================
  Hits         1158     1158           
  Misses         33       33           
  Partials       25       25           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tonybaloney tonybaloney merged commit 9519747 into tonybaloney:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants