Avoid report erroring out if there is no data to show #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
+ Coverage 95.32% 95.33% +0.01%
==========================================
Files 24 24
Lines 1241 1244 +3
Branches 278 279 +1
==========================================
+ Hits 1183 1186 +3
Misses 33 33
Partials 25 25
|
tonybaloney
approved these changes
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
wily report --changes, it's possible to end up with no data to show, which results in anIndexErrorfrom tabulate. In this PR the same guard-clause strategy of #197 is used to avoid that, while logging an error explaining why no output is generated.This fixes an error that surfaced in #201, but I can't see why it would be triggered by that change.