Standalone plotly.min.js for graph (fix #189) #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #209 +/- ##
==========================================
- Coverage 95.84% 95.72% -0.13%
==========================================
Files 25 25
Lines 1349 1356 +7
Branches 289 293 +4
==========================================
+ Hits 1293 1298 +5
- Misses 32 33 +1
- Partials 24 25 +1
☔ View full report in Codecov by Sentry. |
tonybaloney
requested changes
Aug 25, 2023
tonybaloney
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #189, this PR uses Plotly's
include_plotlyjsoption to allow users to choose whether to inline the JS code in the HTML file or add a standaloneplotly.min.jsfile.It actually accepts all values that
include_plotlyjsdoes, allowing one to suppress generation of JS, point to an arbitrary JS file or to a CDN. However, I'd prefer to not advertise these other cases so we only have to care about the simple case of standalone JS file.