Skip to content

Commit

Permalink
Remove qemu_tracing dependency.
Browse files Browse the repository at this point in the history
The feature is not implemented anymore (and has been for a very long time).
Moreover, this will allow us to cleanup hardware/ from any QEMU-specific
items.

BUG=25875346

Change-Id: I71488f4128c737dedf2b28433499fa6ffd29dcb5
  • Loading branch information
digit-android committed Jun 21, 2016
1 parent 44b7339 commit ecc1972
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 39 deletions.
4 changes: 0 additions & 4 deletions libpixelflinger/Android.mk
Expand Up @@ -74,10 +74,6 @@ LOCAL_C_INCLUDES += $(LOCAL_EXPORT_C_INCLUDE_DIRS) \
external/safe-iop/include
LOCAL_SHARED_LIBRARIES := libcutils liblog libutils

# Really this should go away entirely or at least not depend on
# libhardware, but this at least gets us built.
LOCAL_SHARED_LIBRARIES += libhardware_legacy
LOCAL_CFLAGS += -DWITH_LIB_HARDWARE
include $(BUILD_SHARED_LIBRARY)

include $(call all-makefiles-under,$(LOCAL_PATH))
14 changes: 0 additions & 14 deletions libpixelflinger/codeflinger/ARMAssembler.cpp
Expand Up @@ -22,10 +22,6 @@
#include <cutils/log.h>
#include <cutils/properties.h>

#if defined(WITH_LIB_HARDWARE)
#include <hardware_legacy/qemu_tracing.h>
#endif

#include <private/pixelflinger/ggl_context.h>

#include "ARMAssembler.h"
Expand All @@ -48,9 +44,6 @@ ARMAssembler::ARMAssembler(const sp<Assembly>& assembly)
{
mBase = mPC = (uint32_t *)assembly->base();
mDuration = ggl_system_time();
#if defined(WITH_LIB_HARDWARE)
mQemuTracing = true;
#endif
}

ARMAssembler::~ARMAssembler()
Expand Down Expand Up @@ -184,13 +177,6 @@ int ARMAssembler::generate(const char* name)
const char * const format = "generated %s (%d ins) at [%p:%p] in %lld ns\n";
ALOGI(format, name, int(pc()-base()), base(), pc(), duration);

#if defined(WITH_LIB_HARDWARE)
if (__builtin_expect(mQemuTracing, 0)) {
int err = qemu_add_mapping(uintptr_t(base()), name);
mQemuTracing = (err >= 0);
}
#endif

char value[PROPERTY_VALUE_MAX];
property_get("debug.pf.disasm", value, "0");
if (atoi(value) != 0) {
Expand Down
3 changes: 0 additions & 3 deletions libpixelflinger/codeflinger/ARMAssembler.h
Expand Up @@ -167,9 +167,6 @@ class ARMAssembler : public ARMAssemblerInterface
uint32_t* mPC;
uint32_t* mPrologPC;
int64_t mDuration;
#if defined(WITH_LIB_HARDWARE)
bool mQemuTracing;
#endif

struct branch_target_t {
inline branch_target_t() : label(0), pc(0) { }
Expand Down
4 changes: 0 additions & 4 deletions libpixelflinger/codeflinger/MIPS64Assembler.cpp
Expand Up @@ -33,10 +33,6 @@
#include <cutils/log.h>
#include <cutils/properties.h>

#if defined(WITH_LIB_HARDWARE)
#include <hardware_legacy/qemu_tracing.h>
#endif

#include <private/pixelflinger/ggl_context.h>

#include "MIPS64Assembler.h"
Expand Down
11 changes: 0 additions & 11 deletions libpixelflinger/codeflinger/MIPSAssembler.cpp
Expand Up @@ -55,10 +55,6 @@
#include <cutils/log.h>
#include <cutils/properties.h>

#if defined(WITH_LIB_HARDWARE)
#include <hardware_legacy/qemu_tracing.h>
#endif

#include <private/pixelflinger/ggl_context.h>

#include "MIPSAssembler.h"
Expand Down Expand Up @@ -1411,13 +1407,6 @@ int MIPSAssembler::generate(const char* name)
const char * const format = "generated %s (%d ins) at [%p:%p] in %lld ns\n";
ALOGI(format, name, int(pc()-base()), base(), pc(), duration);

#if defined(WITH_LIB_HARDWARE)
if (__builtin_expect(mQemuTracing, 0)) {
int err = qemu_add_mapping(uintptr_t(base()), name);
mQemuTracing = (err >= 0);
}
#endif

char value[PROPERTY_VALUE_MAX];
value[0] = '\0';

Expand Down
3 changes: 0 additions & 3 deletions libpixelflinger/codeflinger/MIPSAssembler.h
Expand Up @@ -410,9 +410,6 @@ class MIPSAssembler
uint32_t* mPC;
uint32_t* mPrologPC;
int64_t mDuration;
#if defined(WITH_LIB_HARDWARE)
bool mQemuTracing;
#endif

struct branch_target_t {
inline branch_target_t() : label(0), pc(0) { }
Expand Down

0 comments on commit ecc1972

Please sign in to comment.