Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing inline editing in case of editable columns with the name id or having key:true property #386

Merged
merged 1 commit into from Dec 9, 2012

Conversation

OlegKi
Copy link
Contributor

@OlegKi OlegKi commented Nov 21, 2012

Hello Tony

as announced before I post the next pull request which do the following:

  1. fixing the code where exists the editable column having name="id".
  2. allowing changing of column having key:true or modifying rowid in any other way (column with name="id"). 

The demo demonstrate the fixed code.

Best regards
Oleg

1) fixing the code where exists the editable column having `name="id"`.
2) allowing changing of column having `key:true` or modifying rowid in any other way (column with `name="id"`). 
tonytomov added a commit that referenced this pull request Dec 9, 2012
Fixing inline editing in case of editable columns with the name id or having key:true property
@tonytomov tonytomov merged commit 0198cd0 into tonytomov:master Dec 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants