Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Tony,
after writing the answer on stackoverflow I analysed the code of jqGrid where
page
,lastpage
andrecords
are used and especially wherepage
will be read from JSON or XML. The current jqGrid code ignore numeric0
input value and additionally resetpage
value0
to1
before starting or reloading (inpopulate
).I suggest to fix the code by usage of existing
intNum
function which do exactly what one needs. Additional advantage will be conversion ofpage
,lastpage
andrecords
directly tonumber
. The parameters will be used in many places of the code in compare operation (like<
or===
) and usage numbers simplify the logic. Moreover one will fix additionally wrong input values ofpage
,lastpage
andrecords
directly to default values.Best regards
Oleg