Add ability for clear search btn to trigger events #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the triggers to the clear search class function allows for custom toolbar search widgets to respond to the user when they click the clear search button in the toolbar search.
Added the ability for a custom toolbar search control to respond to the clear search button being clicked by listening for a change or select event.
we have a use case where the search operators are needed to post back to a server with the field name, operator and value of the filter.
updated the code to account for array's
Updated the clearToolbar function to generate a filters argument for the default values.
wanted to implement support for being able to determine which fields changed and if necessary update UI to reflect.
addressed an empty array issue
comma is to common to show in in formatted names. changed separator to a pipe symbol which should not come up in common text.
this was preventing multi select widgets from wrapping the select element correctly.
we had trouble with positioning the column chooser dialog so we fixed the dialog options to make use of the ui.position in jquery ui.
when string data contains characters like '<' or '&' this generates a error in xml parsers. updated the xml output to check for these two characters and when detected wrap these strings in a CDATA element.
update to last commit
xml elements can not be numbers or empty ie '<0>' or '<>'. When we where dealing with a <value> element for a select we where seeing <0>No</0><1>Yes</1><>All</>. this was invalid xml markup so we added logic to detect this and re write the elements as <No>0</No><Yes>1</Yes><All/>
added the ability for the grid import to restore functions from a export.
some scripts need to be massaged a little before they can be parsed back into a java script method.
|
I understand that a lot of these features were planned for 4.7 however we needed them now. I am not sure if the changes to the scripts are in line with what you had planned. what is the likely hood to include these updates in 4.7? |
minimized the text necessary to parse a function back into a function.
just like the function issue booleans where keeping there string equivalent. 0 = "false" is still true because the string is not null, empty or undefined.
in fire fox and maybe other browsers special characters found in java script functions like '&&','>', and '<'. where not being processed back to there actual and were breaking the import.
updated to use existing code in the jgrid namespace
clean up empty filters
|
Hello, Thank you for posting these commits. I will close this pull request. |
kccarter76
added a commit
to kccarter76/jqGrid
that referenced
this pull request
May 13, 2014
reference to pull request reference request tonytomov#598 for original
kccarter76
added a commit
to kccarter76/jqGrid
that referenced
this pull request
May 13, 2014
refer to pull tonytomov#598
kccarter76
added a commit
to kccarter76/jqGrid
that referenced
this pull request
May 13, 2014
see the original request tonytomov#598
kccarter76
added a commit
to kccarter76/jqGrid
that referenced
this pull request
May 13, 2014
see original pull request tonytomov#598
kccarter76
added a commit
to kccarter76/jqGrid
that referenced
this pull request
May 13, 2014
Added the ability for a custom toolbar search control to respond to the clear search button being clicked by listening for a change or select event. see tonytomov#598 for original
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we use a custom multi-select widget for some of our columns and when the clear search was clicked the control could not reflect the actual value of the underlying select. so we added a trigger for the respective input type to the function below.