Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change webext API calls to use browser instead of chrome #44

Closed
eritbh opened this issue Apr 7, 2019 · 1 comment · Fixed by #213
Closed

Change webext API calls to use browser instead of chrome #44

eritbh opened this issue Apr 7, 2019 · 1 comment · Fixed by #213
Assignees
Milestone

Comments

@eritbh
Copy link
Member

eritbh commented Apr 7, 2019

Firefox implements a promise-based version of Chrome's chrome.* extension API, referenced as browser.*: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API

It also provides a polyfill to support Chrome: https://github.com/mozilla/webextension-polyfill

Given we're converting lots of our code to promises, I think it would make sense to use a promise-based browser API since it doesn't seem like it's otherwise much different (shouldn't require much logic rewriting, just cleanup).

@creesch
Copy link
Member

creesch commented Apr 7, 2019

Yeah the problem with that used to be edge, with edge switching to chromium that hopefully shouldn't be an issue anymore.

@eritbh eritbh self-assigned this Apr 7, 2019
@eritbh eritbh added this to the 4.0.19/4.1.0 milestone Apr 7, 2019
@creesch creesch modified the milestones: 4.0.19/4.1.0, v5.1 May 23, 2019
@eritbh eritbh modified the milestones: v5.1.x, v5.2.x Aug 13, 2019
@eritbh eritbh mentioned this issue Oct 14, 2019
4 tasks
@eritbh eritbh added this to In progress in Big refactoring projects Nov 20, 2019
@eritbh eritbh modified the milestones: v5.x, v5.3 Mar 10, 2020
@eritbh eritbh moved this from In progress to Done in Big refactoring projects Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants