Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework project formatting #784

Closed
eritbh opened this issue Jul 13, 2023 · 0 comments · Fixed by #811
Closed

Rework project formatting #784

eritbh opened this issue Jul 13, 2023 · 0 comments · Fixed by #811
Assignees
Labels
code quality meta concerns related to releasing/maintenance/etc that don't rely on changes to extension code

Comments

@eritbh
Copy link
Member

eritbh commented Jul 13, 2023

We're moving to Typescript (#761) and eslint and eslint-typescript no longer recommend using themselves as formatting tools. The TS PR #783 includes no formatting for Typescript files and we're gonna have to move our project's formatting config to something else (probably prettier, maybe dprint). This will probably involve reformatting the entire codebase under a new standard, because this repo's existing conventions are different from exosystem standards and I don't really feel like writing a whole new config for a new tool.

Any PR that reformats the project should add a .git-blame-ignore-revs file for the commit that actually applies the new formatting, and that PR should not be squash-merged to make sure that the commit referenced there maintains the correct SHA and doesn't contain non-automated changes.

@eritbh eritbh added code quality meta concerns related to releasing/maintenance/etc that don't rely on changes to extension code labels Jul 13, 2023
@eritbh eritbh added this to Brainstorm in Big refactoring projects via automation Jul 13, 2023
@eritbh eritbh self-assigned this Aug 10, 2023
Big refactoring projects automation moved this from Brainstorm to Done Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality meta concerns related to releasing/maintenance/etc that don't rely on changes to extension code
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant