Skip to content
This repository has been archived by the owner on May 24, 2023. It is now read-only.

Don't enforce web as procfile entry #21

Merged
merged 1 commit into from
May 23, 2023
Merged

Don't enforce web as procfile entry #21

merged 1 commit into from
May 23, 2023

Conversation

david-caro
Copy link
Contributor

This allows using any other name, and will use the first one it find as the default command.

We might want to change the way we start bulidservice images too to pick the web procfile entry, or not :)

Bug: T336050

This allows using any other name, and will use the first one it find
as the default command.

We might want to change the way we start bulidservice images too to
pick the web procfile entry, or not :)

Bug: T336050
Signed-off-by: David Caro <dcaro@wikimedia.org>
@supertassu
Copy link
Member

We might want to change the way we start bulidservice images too to pick the web procfile entry, or not :)

I think we should do that, yes.

@david-caro
Copy link
Contributor Author

We might want to change the way we start bulidservice images too to pick the web procfile entry, or not :)

I think we should do that, yes.

I think that it would be a good idea to allow the user to start different applications (be that webservices or not), and for that, they could use the same image, just changing the entrypoint (see https://phabricator.wikimedia.org/T337191#8870190).

This would mean in the future having something like 'toolforge app start --command frontend' and something like 'toolforge app start --command backend' using the same buildservice image, but just different entrypoints in the procfile.

Though as we currently only have webservice, it might make sense to use web for it, but once we have more than one, we should allow the user to specify whichever they want 👍

@NdibeRaymond
Copy link
Contributor

+1. building was successful

@david-caro david-caro merged commit b693137 into main May 23, 2023
@david-caro david-caro deleted the allow_no_web_entry branch May 23, 2023 07:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants