Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ToolsDB credentials #40

Merged
merged 2 commits into from
May 20, 2024
Merged

Add ToolsDB credentials #40

merged 2 commits into from
May 20, 2024

Conversation

dhinus
Copy link
Member

@dhinus dhinus commented May 20, 2024

This will let Quarry run queries against the ToolsDB replica host.

Bug: T348407

@dhinus dhinus requested a review from vivian-rook May 20, 2024 10:30
@siddharthvp
Copy link
Collaborator

The conf keys should be TOOLS_DB_* instead of TOOLSDB_*, to match the ones in default-config.yaml.

Otherwise, LGTM. Thanks!

This will let Quarry run queries against the ToolsDB replica host.

Bug: T348407
@dhinus
Copy link
Member Author

dhinus commented May 20, 2024

Good catch, thanks. I also removed TOOLS_DB_HOST from the encrypted file and modified the hostname directly in default-config.yaml.

@vivian-rook vivian-rook merged commit c417f9f into main May 20, 2024
3 checks passed
@vivian-rook vivian-rook deleted the toolsdb branch May 20, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants