fix: Income vs Expense Report could show NaN% savings ratio (#3049)

toolkit-for-ynab · Mar 29, 2023 · 381995f · 381995f
1 parent 979c927
commit 381995f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...oolkit-reports/pages/income-vs-expense/components/monthly-savings-ratio-row/component.jsx b/...oolkit-reports/pages/income-vs-expense/components/monthly-savings-ratio-row/component.jsx
@@ -17,7 +17,7 @@ export const MonthlySavingsRatioRow = (props) => {
   );
 
   let allMonthsRatioTotal = 0;
-  if (allMonthsIncomeTotal >= allMonthsExpenseTotal) {
+  if (allMonthsIncomeTotal !== 0 && allMonthsIncomeTotal >= allMonthsExpenseTotal) {
     allMonthsRatioTotal = 1 - allMonthsExpenseTotal / allMonthsIncomeTotal;
   }
 
@@ -38,7 +38,7 @@ export const MonthlySavingsRatioRow = (props) => {
           const incomeTotal = incomeMonthData.get('total');
           const expenseTotal = Math.abs(expenseMonthData.get('total'));
           let ratio = 0;
-          if (incomeTotal >= expenseTotal) {
+          if (incomeTotal !== 0 && incomeTotal >= expenseTotal) {
             ratio = 1 - expenseTotal / incomeTotal;
           }