Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Pacing layout is broken in Budget section #2845

Closed
thomasburguiere opened this issue Jul 13, 2022 · 15 comments · Fixed by #2922
Closed

[BUG] Pacing layout is broken in Budget section #2845

thomasburguiere opened this issue Jul 13, 2022 · 15 comments · Fixed by #2922
Labels
bug Something isn't working pr created A PR has been opened that solves this issue

Comments

@thomasburguiere
Copy link
Contributor

thomasburguiere commented Jul 13, 2022

Describe the bug
When display Pacing in the Budget section, the layout is now broken, since the last YNAB update (July 11th, 2022)

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Toolkit for YNAB Options'
  2. Click on 'Budget tab'
  3. Click on 'Add Pacing'
  4. Go to 'YNAB'
  5. Open the 'Budget' Tab

Expected behavior
the pacing is properly displayed

Screenshots

Screenshot 2022-07-13 at 09 16 50

Desktop (please complete the following information):

  • OS: macOS 12.4
  • Browser firefox 102.0.1
  • Toolkit Version 3.3.3

Setting Export

[{"key":"AccountsDisplayDensity","value":"1"},{"key":"AccountsEmphasizedInflows","value":true},{"key":"AccountsEmphasizedOutflows","value":false},{"key":"AccountsStripedRows","value":false},{"key":"AccountsStripedRowsColor","value":"#fafafa"},{"key":"AccountsStripedRowsDarkColor","value":"#1e1e1f"},{"key":"AssistedClear","value":false},{"key":"AutoDistributeSplits","value":false},{"key":"AutoEnableRunningBalance","value":false},{"key":"AutomaticallyMarkAsCleared","value":false},{"key":"BetterScrollbars","value":false},{"key":"BottomNotificationBar","value":false},{"key":"BudgetProgressBars","value":false},{"key":"BudgetQuickSwitch","value":false},{"key":"BulkEditMemo","value":true},{"key":"BulkManagePayees","value":true},{"key":"CalculateIRR","value":false},{"key":"CalendarFirstDay","value":"1"},{"key":"CategoryActivityCopy","value":false},{"key":"CategoryActivityPopupWidth","value":"2"},{"key":"ChangeEnterBehavior","value":true},{"key":"ChangeMemoEnterBehavior","value":false},{"key":"CheckCreditBalances","value":false},{"key":"CheckNumbers","value":false},{"key":"ClearSelection","value":false},{"key":"CollapseInspector","value":false},{"key":"CompactIncomeVsExpense","value":true},{"key":"ConfirmEditTransactionCancellation","value":false},{"key":"CreditCardEmoji","value":false},{"key":"CtrlEnterCleared","value":false},{"key":"CurrentMonthIndicator","value":false},{"key":"CustomAverageBudgeting","value":false},{"key":"CustomFlagNames","value":false},{"key":"CustomizeColourScheme","value":false},{"key":"DateOfMoney","value":true},{"key":"DaysOfBuffering","value":"all"},{"key":"DaysOfBufferingExcludeCreditCards","value":false},{"key":"DefaultCCToCleared","value":false},{"key":"DeselectTransactionsOnSave","value":false},{"key":"DisableToolkit","value":false},{"key":"DisplayMonthlyGoalsOverview","value":true},{"key":"DisplayTargetGoalAmount","value":false},{"key":"DisplayTotalMonthlyGoals","value":false},{"key":"DisplayTotalOverspent","value":false},{"key":"DisplayUpcomingAmount","value":true},{"key":"EasyTransactionApproval","value":false},{"key":"EditAccountButton","value":false},{"key":"EnlargeCategoriesDropdown","value":true},{"key":"FilterCategories","value":true},{"key":"GoalIndicator","value":false},{"key":"GoalWarningColor","value":false},{"key":"GoogleFontsSelector","value":false},{"key":"HideAccountBalancesType","value":false},{"key":"HideAgeOfMoney","value":false},{"key":"HideClosedAccounts","value":false},{"key":"HideDebtRatio","value":false},{"key":"HideHelp","value":true},{"key":"HideReferralBanner","value":true},{"key":"HighlightNegatives","value":false},{"key":"HoveredBudgetRows","value":true},{"key":"ImportNotification","value":false},{"key":"IncomeVsExpenseHoverHighlight","value":true},{"key":"LargerClickableIcons","value":false},{"key":"LiveOnLastMonthsIncome","value":false},{"key":"MasterCategoryRowColor","value":false},{"key":"MasterCategoryRowColorSelect","value":"#d1d1d6"},{"key":"MasterCategoryRowDarkColorSelect","value":"#636366"},{"key":"MemoAsMarkdown","value":true},{"key":"MonthlyNotesPopupWidth","value":false},{"key":"NavDisplayDensity","value":"1"},{"key":"NotesAsMarkdown","value":true},{"key":"POSStyleCurrencyEntryMode","value":true},{"key":"Pacing","value":"1"},{"key":"PrintingImprovements","value":true},{"key":"PrivacyMode","value":false},{"key":"QuickBudgetWarning","value":false},{"key":"ReconcileAssistant","value":false},{"key":"ReconcileBalance","value":false},{"key":"ReconcileConfetti","value":false},{"key":"ReconciledTextColor","value":false},{"key":"RemovePositiveHighlight","value":false},{"key":"RemoveZeroCategories","value":false},{"key":"RightClickToEdit","value":true},{"key":"RowHeight","value":"1"},{"key":"RowsHeight","value":"3"},{"key":"SavingsRatio","value":"0.60"},{"key":"ScrollableEditMenu","value":false},{"key":"ShowAvailableAfterSavings","value":false},{"key":"ShowCategoryBalance","value":false},{"key":"SpareChange","value":false},{"key":"SplitTransactionAutoAdjust","value":false},{"key":"SplitTransactionAutoFillPayee","value":false},{"key":"SplitTransactionTabExpand","value":false},{"key":"SquareNegativeMode","value":false},{"key":"StealingFromFuture","value":false},{"key":"StripedBudgetRows","value":false},{"key":"SubtractUpcomingFromAvailable","value":"1"},{"key":"SwapClearedFlagged","value":false},{"key":"TargetBalanceWarning","value":false},{"key":"ToBeBudgetedWarning","value":false},{"key":"ToggleAccountColumns","value":true},{"key":"ToggleMasterCategories","value":true},{"key":"ToggleSplits","value":false},{"key":"ToggleTransactionFilters","value":"1"},{"key":"ToolkitReports","value":true},{"key":"UnclearedAccountHighlight","value":true},{"key":"ViewZeroAsEmpty","value":true},{"key":"options.dark-mode","value":false}]
@thomasburguiere thomasburguiere changed the title [BUG] Pacing layout is broken in Budget section, since the last YNAB update [BUG] Pacing layout is broken in Budget section Jul 13, 2022
@sundowwner
Copy link

I'm also showing the same issue with pacing.

pacing

@am307009
Copy link

am307009 commented Jul 19, 2022

i am showing the same issue with pacing in windows for chrome

edit to add: also showing the issue in windows for edge

@reinmcha
Copy link

I am showing the same issue.

@ScottLangridge
Copy link

+1 for the pacing issue.

Pacing actually seems to be hidden entirely by default now though. The only way I can get it to show up, even with the broken layout is to go into the settings and toggle it off and on again. (After that it will stay until I refresh the page)

@ScottLangridge
Copy link

Note for anyone else experiencing this, the pacing bar on Budget Rows Progress Bars still works. You get less information than from the dedicated column, but it will at least show you if you're ahead or behind at a glance

@thomasburguiere
Copy link
Contributor Author

thomasburguiere commented Aug 2, 2022

+1 for the pacing issue.

Pacing actually seems to be hidden entirely by default now though. The only way I can get it to show up, even with the broken layout is to go into the settings and toggle it off and on again. (After that it will stay until I refresh the page)

Indeed, forgot to mention that in the initial issue, same behaviour for me :)

@nadia26
Copy link

nadia26 commented Aug 3, 2022

+1

1 similar comment
@RWTL
Copy link

RWTL commented Aug 3, 2022

+1

@hdhanoa
Copy link

hdhanoa commented Aug 5, 2022

The issue appears to be connected to the use of the <li> tags for the pacing elements. Converting them to <div> tags appears to resolve the issue. Alternatively, if <li> tags are preferred, "style="list-style: none;" can be included in the tags to remove the bullet.

@InfraRogue
Copy link

Any updates on this? Pacing is one of the tools I use every single day to evaluate my budget and this has been broken for me for weeks.

@InsouciantQualms
Copy link

I have a different issue. MacOSX running Chrome. The pacing indicators are totally gone. Happened a couple of weeks ago.

@thomasburguiere
Copy link
Contributor Author

I have a different issue. MacOSX running Chrome. The pacing indicators are totally gone. Happened a couple of weeks ago.

It's the same issue I would say. As a workaround you can go to the extension settings, then disable and re enable pacing
It should then be displayed with the broken layout

Pacing will be hidden next time you reload the page

@InsouciantQualms
Copy link

That worked! Thanks so much.

@avanzal
Copy link

avanzal commented Aug 17, 2022

+1

Good feature but it has been broken for a few weeks now. As described by others - the styling is broken (see screenshot) and the pacing column doesn't show when I re-open YNAB (have to go into toolkit settings and disable + re-enable pacing feature each time I load YNAB to get it to show).

Toolkit 3.3.5 using latest Chrome on Windows:
image

@blalockma
Copy link
Contributor

If anyone wants a branch to have it working in the meantime, I put this into a PR. Enjoy :)

#2922

@michaelcmelton michaelcmelton added pr created A PR has been opened that solves this issue bug Something isn't working labels Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pr created A PR has been opened that solves this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.