Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Budget-Pacing CSS to work with new YNAB cell styles. #2922

Merged
merged 2 commits into from Aug 31, 2022
Merged

Update Budget-Pacing CSS to work with new YNAB cell styles. #2922

merged 2 commits into from Aug 31, 2022

Conversation

blalockma
Copy link
Contributor

GitHub Issue (if applicable): #2918 and #2845

Explanation of Bugfix/Feature/Modification:

  • Update Pacing Budget feature to show on page load instead of only when toggling.
  • Update the styling back to the current YNAB CSS styles.

Before:
image

After:
image

@joshmadewell
Copy link
Member

@blalockma Sorry for the delay on this, if you could fix the eslint errors, i'll get this in!

@blalockma
Copy link
Contributor Author

@joshmadewell thanks for the help! Pushed a commit that should fix the eslint issue. Could you rerun the workflow and try? :)

@michaelcmelton michaelcmelton linked an issue Aug 28, 2022 that may be closed by this pull request
@blalockma
Copy link
Contributor Author

@joshmadewell Can this get merged? :) It doesn't look like I have permissions to.

@joshmadewell
Copy link
Member

I'll go ahead and merge it so it's in main but it'll be a few days I think before I can get to the release. Thanks for the fix!

@joshmadewell joshmadewell merged commit 2a819d6 into toolkit-for-ynab:main Aug 31, 2022
@blalockma
Copy link
Contributor Author

Thanks!! No problem at all :) Just wanted to remove it from my brain.

@blalockma blalockma deleted the bug/fix-pacing branch August 31, 2022 12:29
@am307009
Copy link

am307009 commented Sep 6, 2022

Is there something we have to do to get the fix working? Like update the browser or something? It still looks broken to me

@blalockma
Copy link
Contributor Author

It's not in the latest release yet. @am307009

@ScottLangridge
Copy link

Is there any approximate timeline on when this will be included in a release?

@williammck williammck linked an issue Oct 9, 2022 that may be closed by this pull request
@blalockma
Copy link
Contributor Author

Is there any approximate timeline on when this will be included in a release?

This fix has been in since version 3.3.6

Let me know if there's anything I missed but it looks correct :)

@ScottLangridge
Copy link

Hi @blalockma, sorry for the delay, I didn't see your reply. I'm on 3.4.0 and it's still misaligned for me (and a friend on his account and machine).

Let me know if there's any more information I can give you to help

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pacing not staying up [BUG] Pacing layout is broken in Budget section
4 participants