Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: forecast starting net worth using all transactions instead of only filtered #2706

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

ssartell
Copy link
Contributor

@ssartell ssartell commented Mar 22, 2022

GitHub Issue (if applicable): n/a

Trello Link (if applicable): n/a

Explanation of Bugfix/Feature/Modification:
The current forecast report bases the starting net worth off only the filtered transactions. This updates it to use all transactions (filtered by account but not date) to calculate the net worth, but keeps the filtered transactions (account and date) for running the simulation.

@ssartell ssartell changed the title Fix forecast net worth using all transctions Fix: forecast net worth using all transactions instead of only filtered Mar 22, 2022
@ssartell ssartell changed the title Fix: forecast net worth using all transactions instead of only filtered Fix: forecast starting net worth using all transactions instead of only filtered Mar 22, 2022
@narthur
Copy link
Contributor

narthur commented Apr 6, 2022

Very nice! My only concern is that it would be nice if you could forecast the future balance of a single category or the entire budget. This PR means you can forecast the entire budget's balance with filtered inputs, but doesn't allow for forecasting a single category's future balance. Not sure what the right solution is for that...

@ssartell
Copy link
Contributor Author

ssartell commented Apr 6, 2022

@narthur you're right, this doesn't account for selecting specific categories and only works if you're forecasting your entire budget which is what I was looking to do. So if you did select a specific set of categories, would you expect your starting balance of the forecast to be the total available dollars in all of those categories?

@narthur
Copy link
Contributor

narthur commented Apr 6, 2022

@ssartell I think that's what I'd want, yes. 🤔

@joshmadewell
Copy link
Member

@narthur @ssartell I don't really use this report at all so somewhat deferring to whether y'all think we should change this?

@michaelcmelton michaelcmelton added this to In progress in toolkit-for-ynab via automation Apr 30, 2022
@michaelcmelton michaelcmelton moved this from In progress to Review in progress in toolkit-for-ynab Apr 30, 2022
@joshmadewell
Copy link
Member

OK, looking at the report and testing this locally...I think this makes sense to me a change worth making. I reckon if users don't like it...we'll hear about it.

I agree it would be interesting to respect categories across the board as filters so we could forecast categories.

toolkit-for-ynab automation moved this from Review in progress to Reviewer approved Jun 29, 2022
@joshmadewell joshmadewell merged commit 211a719 into toolkit-for-ynab:main Jun 29, 2022
toolkit-for-ynab automation moved this from Reviewer approved to Done Jun 29, 2022
HelloThisIsFlo pushed a commit to HelloThisIsFlo/toolkit-for-ynab that referenced this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants