fix: rewrite striped-rows to remember row status (#1490) #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhpickering
changed the title
|
I'm not actually able to reproduce the issue this intends to fix 🤔 Is it possible this isn't an issue anymore? |
joshmadewell
approved these changes
Jun 14, 2022
HelloThisIsFlo
pushed a commit
to HelloThisIsFlo/toolkit-for-ynab
that referenced
this pull request
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (if applicable): #1490
Trello Link (if applicable):
Explanation of Bugfix/Feature/Modification:
The striped rows feature in the account screen was previously entirely CSS, based on whether the row was odd or even. This meant as the row elements were created and destroyed when scrolling, the colour of any single row could alternate. I've rewritten the feature to manually set row colour and base the stripe pattern on any existing rows when scrolling.