Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calendar shifts when First day of the week is enabled ( #2761) #2762

Merged
merged 1 commit into from
May 29, 2022

Conversation

AAraKKe
Copy link
Contributor

@AAraKKe AAraKKe commented May 28, 2022

GitHub Issue (if applicable): #2761

Explanation of Bugfix/Feature/Modification:
I modified where the tkShifted data attribute is added to allow the guard supplied to the onElement method to work since the querySelector will return null if the attribute is in the same element where we are querying.

@joshmadewell
Copy link
Member

ah yeah...i made onElement (this is such a bad name, plz no judge lol) look at the element passed in after i'd already fixed this feature with it....honestly...I think I should maybe change that back to just checking the dom :( either way...i'll take this PR for now and update if needed. thanks!

@joshmadewell joshmadewell merged commit 86c514a into toolkit-for-ynab:main May 29, 2022
HelloThisIsFlo pushed a commit to HelloThisIsFlo/toolkit-for-ynab that referenced this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants