#2794 add variable background color to button #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelcmelton
added
pr created
michaelcmelton
removed
pr created
joshmadewell
approved these changes
Jun 29, 2022
HelloThisIsFlo
pushed a commit
to HelloThisIsFlo/toolkit-for-ynab
that referenced
this pull request
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (if applicable): #2794
Explanation of Bugfix/Feature/Modification:
The button is near invisible unless you use the dark mode in YNAB, because it uses the
--sidebar_label_primaryvariable which is white.This change adds a background color based on
--sidebar_background, which should always contrast nicely with the label.