Fix report rendering and custom average budget feature #2825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (if applicable): #2822 and #2821
Explanation of Bugfix/Feature/Modification:
#2822: We were double parsing
collapsedSources
which was causing a throw to happen fromJSON.parse
#2821: Made sure to always put the button after the other "Average Spent" button and also fixed some broken logic with the arithmetic and stuff. I think my changes made
_calculateAverage()
return a string instead of a number which broke some stuff. Also, we were subtracting too many months from start month.