Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Internal Rate of Return #2929

Merged
merged 1 commit into from Sep 4, 2022
Merged

Fix Internal Rate of Return #2929

merged 1 commit into from Sep 4, 2022

Conversation

regenvanwalbeek
Copy link
Contributor

GitHub Issue (if applicable): #2897

Trello Link (if applicable):

Explanation of Bugfix/Feature/Modification:
The internal rate of return calculation is broken. It appears that selectedAccount is no longer available from the controllerLookup, so I switched it to use the serviceLookup.

@regenvanwalbeek
Fix toolkit-for-ynab#2897
2bf6096 
- selectedAccount no longer exists on controllerLookup
@regenvanwalbeek regenvanwalbeek changed the title Fix #2897 Fix Internal Rate of Return Sep 4, 2022
joshmadewell
joshmadewell approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@joshmadewell joshmadewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that aught to do it, thanks!

@joshmadewell joshmadewell merged commit 581e4c1 into toolkit-for-ynab:main Sep 4, 2022
@williammck williammck linked an issue Oct 9, 2022 that may be closed by this pull request
Internal Rate of Return in accounts no longer works #2897
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmadewell joshmadewell joshmadewell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal Rate of Return in accounts no longer works
2 participants
@regenvanwalbeek @joshmadewell