Fixed total monthly goals, following YNAB switch to glimmer #2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really appreciate this PR since I am personally affected by this. I checked this locally and I can see the "Total monthly goals" tab. |
joshmadewell
approved these changes
Oct 3, 2022
|
Thanks to everyone who worked on this fix! Is there any ETA on when this fix will get released? |
|
Also fixes #2947. |
This was
linked to
issues
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (if applicable): #2948, #2946
Trello Link (if applicable):
Explanation of Bugfix/Feature/Modification:
Apparently, YNAB is in the process of changing Ember components over to Glimmer. That broke a couple features, as explained by @williammck in a similar bugfix PR.
I had to do some playing around to find a node that would change when you go between having specific categories checked and having no categories checked. I think this
budget-inspector-buttonshould do the trick...