feat(goal-display): Implement Sum Goal Display on Master Category #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CSS is definitely up for debate here. |
joshmadewell
requested changes
Nov 20, 2022
|
Migrated to existing feature in 685d285 |
src/extension/features/feature.ts
Outdated
| @@ -48,7 +48,7 @@ export class Feature { | |||
| /* stubbed listener function */ | |||
| } | |||
|
|
|||
| onRouteChanged(): void { | |||
| onRouteChanged(route: any): void { | |||
There was a problem hiding this comment.
do we need this type? i think if we're going to add this, it should be string not any.
in general, if we're adding types we should never use any, especially in our own code.
There was a problem hiding this comment.
I'll revert. Not sure why I added in the first place.
| @@ -87,6 +87,28 @@ export class FilterCategories extends Feature { | |||
| return; | |||
| } | |||
|
|
|||
| if (/^goal$/g.test(text)) { | |||
There was a problem hiding this comment.
sneaking this in i see 👀 haha
joshmadewell
approved these changes
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (if applicable): #2978
Implements a new feature to display sum goal amounts on the master category row, screenshot below.
This also augments the category filter for both goal and non-goal categories with a
goaland-goalkeyword.