Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update selector for referral banner #3023

Merged
merged 1 commit into from Jan 28, 2023
Merged

fix: Update selector for referral banner #3023

merged 1 commit into from Jan 28, 2023

Conversation

michaelcmelton
Copy link
Contributor

Closes #3022

@williammck
Copy link
Member

It's still div.referral-program for me... is YNAB testing something?
Let's keep both.

@williammck
Copy link
Member

It's still div.referral-program for me... is YNAB testing something? Let's keep both.

Ah, yep, there's a referral-banner-experiment feature flag. Apologies @alexmidd, that's why I couldn't replicate it on my end.

@williammck williammck mentioned this pull request Nov 24, 2022
Closed
@joshmadewell joshmadewell merged commit 97a7994 into toolkit-for-ynab:main Jan 28, 2023
@matthew-e-brown matthew-e-brown mentioned this pull request Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmadewell joshmadewell joshmadewell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Hide Referral Banner" toggle not working
3 participants
@michaelcmelton @williammck @joshmadewell