Target goal total 3034 #3035
Merged
Target goal total 3034 #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (if applicable): #3034
Trello Link (if applicable):
Explanation of Bugfix/Feature/Modification:
A clear and concise description of what changes you've made and why.
The logic for retrieving the category 'goal target' in the addTargetGoalAmount method was different from the logic in the _addSums method. I have updated _addSums to use the monthlySubCategoryBudgetCalculation property.
If 'Goal Indicator' option is enabled, the total figure in pushed to the left by 1.5em to allow for the 'total' to be roughly above the category 'goals' (this is only roughly, because goal indicators are variable width).
Switching from em to rem for font size for .tk-budget-table-cell-goal to ensure that the 'total' font size to be the same as that of the category 'goals'.