fix: #3086 copy transactions to clipboard from modal #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmadewell
approved these changes
May 6, 2023
joshmadewell
approved these changes
May 6, 2023
HelloThisIsFlo
pushed a commit
to HelloThisIsFlo/toolkit-for-ynab
that referenced
this pull request
Jun 13, 2023
…oolkit-for-ynab#3102) Co-authored-by: Josh Madewell <joshmadewell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (if applicable): #3086
Explanation of Bugfix/Feature/Modification:
The copy transactions to clipboard buttons were no longer appearing on the activity transaction modals on the budget or reports routes. I wasn't able to resolve this issue without changing the method that the feature is invoked and added to the modals. One of the modals was inaccessible via an ember hook, therefore I changed to utilizing the observe function to invoke the addition of the button. I rewrote the entirety of this function in TS, as well as changed the method to copy to clipboard to a method that is not deprecated.