fix: #3079 Add date filtering util to outflow-over-time #3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
joshmadewell
approved these changes
Jul 12, 2023
|
looks good, thank you! also thank you for the nice words :D |
|
Awesome work @kevinwpeters17 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (if applicable): #3079
In the current state, the
Outflow Over Timereport does not appropriately filter transactions by the date ranges.In the above screenshot, notice the date range is only for
June 2023 - June 2023so only transactions from June 2023 or (2023-06in the legend) should appear in the graph. However, all month/year combinations from the accounts' history show up.Trello Link (if applicable):
Explanation of Bugfix/Feature/Modification:
I added a new function
filterTransactionsByDatethat filters the passed transactions with the from and to dates available in the filters context:filters.dateFilter. I also added a few small comments to contextualize variables.This now properly shows only the transactions that exist within the date range for the selected accounts. Here is the current month:
Sample of the latest three months:
Sample of this year:
As a random note, thank you to @simonjohansson for building this out in the first place! And for all the maintainers of this project.