-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
highlight mis-budgeted CC accounts in budgets nav #3219
highlight mis-budgeted CC accounts in budgets nav #3219
Conversation
This augments the check-credit-balances feature to also add a warning icon to the corresponding account (in the Accounts nav) when it's out of sync with its budget. This slightly tweaks the existing logic, in that it now always sets the budget's background to the warning color, instead of only doing so when the available amount is non-negative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! thanks!
+1, love this feature. Thanks! |
@yshavit @joshmadewell Would it be possible to remove or move the warning icon displayed by this feature? A warning icon in that location is how YNAB warns people of an issue with Direct Import. A significant amount of people are writing in confused thinking they have a Direct Import warning because of this feature. I'd be happy to open a PR too. Thanks! |
@shama I think the "broken direct import" warning is actually a bit different (in location and logo), but your point is well taken! Do you have a suggestion for something you would have found more intuitive? |
@yshavit I think the design issue is this is trying to highlight a budget issue by putting a warning on an account, and so people think something is wrong with the account. IMO I think the warning should be removed from the account but I'm not familiar enough with this toolkit feature beyond with what people are writing in about. |
@shama I see what you mean. I was consciously trying to put it higher up on the page (not just in the budgets section — for me, the CC budgets are low down), but I'm happy to change that. Two options I can think of, off the top of my head:
Do you have a preference between those two? I kinda like the second, personally — and it'd be much easier to implement (since I wouldn't have to figure out anything new, just tweak the HTML that gets inserted). |
btw, to me there is something wrong with the account in the context of my budget. It really is, "hey, your My Credit Card account has something funky with it" (specifically, its associated budget is mistaken). That's why I put it there — not trying to belabor the point, just to explain my mental model. |
@yshavit Thanks! That makes sense. It's always surprising how sometimes a small detail can trip people up. I think either one of those would be an improvement. I very much appreciate your willingness to make this change and just let me know if I can help. |
Instead of a warning, use a more explicit `≠` symbol. This helps differentiate it from a warning about the account having a connection problem. See discussion at toolkit-for-ynab#3219.
@shama I put up PR #3226 to change it to a (If you want to take a stab at moving it to something like a custom view in the budget, that's great too! Otherwise, I'll take a look Tuesday-ish) |
* change the CC-budget-mismatch icon Instead of a warning, use a more explicit `≠` symbol. This helps differentiate it from a warning about the account having a connection problem. See discussion at #3219. * tweak feature description for CC budget mismatch
GitHub Issue (if applicable): none
Trello Link (if applicable): none
Explanation of Bugfix/Feature/Modification:
This augments the check-credit-balances feature to also add a warning icon to the corresponding account (in the Accounts nav) when it's out of sync with its budget.
This slightly tweaks the existing logic, in that it now always sets the budget's background to the warning color, instead of only doing so when the available amount is non-negative.
Since we always try to pay off our credit cards in full via autopay, we typically don't pay attention to the credit card rows in the budget list. However, the budget amount and the account balance will often go out of sync (I'm not sure why — I'm still trying to catch it in the act!). This feature makes the mismatch more immediately visible.