Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove right click to edit now that YNAB has it natively #3237

Merged

Conversation

ahatzz11
Copy link
Contributor

@ahatzz11 ahatzz11 commented Sep 13, 2023

YNAB recently introduced their own new editing experience, which includes right click to edit. Since then, it seems that having this turned on in the toolkit causes the app to freeze. This PR removes the feature from the toolkit since it is now a native feature.

If there is an official deprecation process please let me know. Hopefully YNAB keeps adding more and more features from the toolkit directly!

fixes #3236

@ahatzz11 ahatzz11 marked this pull request as ready for review September 13, 2023 14:19
@ahatzz11 ahatzz11 changed the title Remove right click to edit fix: Remove right click to edit now that YNAB has it natively Sep 13, 2023
Copy link
Member

@joshmadewell joshmadewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, this is indeed the way to deprecate a feature :D thanks!

@joshmadewell joshmadewell merged commit ad42f34 into toolkit-for-ynab:main Sep 13, 2023
2 checks passed
@ahatzz11 ahatzz11 deleted the remove-right-click-to-edit branch September 13, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Right clicking on transactions freezes the app
2 participants