Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #3283

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Fix CI #3283

merged 3 commits into from
Nov 5, 2023

Conversation

OlegWock
Copy link
Contributor

@OlegWock OlegWock commented Nov 2, 2023

GitHub Issue (if applicable): n/a

Trello Link (if applicable):

Explanation of Bugfix/Feature/Modification:
Now borales/actions-yarn@v3.0.0 uses Node 20 by default, which isn't compatible with our current package.json. This PR updated CI actions to setup correct version of node from .nvmrc. I think we should be safe switching to Node 20, but I wasn't 100% sure (I there is probably a reason version is limited to <=19 in package json) so I think this solution is better. To switch to Node 20 (or any other version) we'll just need to change it in package.json and .nvmrc

@joshmadewell
Copy link
Member

I don't think we're tied to any version of node tbch. If the project builds on node 20, we can bump whatever we need to bump

@OlegWock
Copy link
Contributor Author

OlegWock commented Nov 2, 2023

I just checked, seem to compile fine using node 20. So we can either bump version to 20 or just remove limit on max version (so it will be just >=18.12.1)

@joshmadewell
Copy link
Member

removing the max sounds right to me 👍

@OlegWock
Copy link
Contributor Author

OlegWock commented Nov 2, 2023

Done

@joshmadewell joshmadewell merged commit 8ae3859 into toolkit-for-ynab:main Nov 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants