fix: income not shown on split transactions in income-breakdown #3320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjwelde
force-pushed
the
tw-fix-income-breakdown
branch
from
a5719e6
to
f0ec457
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (if applicable): #3243
(The linked issue is mentioning an outflow in the split, so not 100% sure, if their scenario is the same as mine)
Trello Link (if applicable): n/a
Explanation of Bugfix/Feature/Modification:
The Income-Breakdown toolkit report didn't show income assigned as "Inflow: Ready to assign", when using split transactions.
This happened because a non-existant property was used to find the parent transaction payee id.
Example Transaction:
Before:
After:
