chore(core): partial scripts TS conversion #3353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakehamtexas
commented
Jan 16, 2024
Comment on lines
+31
to
+33
| archiver.directory(file, file); | ||
| } else { | ||
| archiver.file(file, { name: file }); |
There was a problem hiding this comment.
These lines used to omit the second argument to archive.directory and archive.file. I read the source code for the archiver package and determined that passing the same path in the second argument would yield the equivalent behavior.
jakehamtexas
force-pushed
the
ts-conversion
branch
from
258dfc6
to
d836ea4
Compare
joshmadewell
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Bugfix/Feature/Modification:
This is a partial conversion attempt for the
scriptsdir in the repo root. I wanted to stop before the diff got too out of control.This accomplishes the following:
ts-nodedependency.scripts/libdir based on some commonalities observed between all of the scriptscompressSrc.tsandcompressDist.tsOnce this is merged, I'll work on the remaining
scriptsdir, and then move on to the application code.I ran all of the scripts that I converted, they seemed to do what they had before conversion/refactoring.