Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add tsc to CI checks, prepush, and dynamic checks workflow #3358

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

jakehamtexas
Copy link
Contributor

GitHub Issue (if applicable): #XXX

Explanation of Bugfix/Feature/Modification:
This PR:

  • Adds tsc to the checks done against code in CI
  • Creates a dynamic framework for adding and running check scripts in precommit, prepush, and GitHub CI

If this is accepted, the required workflows for the protected main branch should be changed to refer to checks.yml exclusively. Any new checks can be managed using the framework (documented in the README), and additional overhead of managing future branch protection rules for required workflows can be eliminated.

Copy link
Member

@joshmadewell joshmadewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seeems reasonable, thanks!

@joshmadewell joshmadewell merged commit 3ada27b into toolkit-for-ynab:main Feb 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants