Fix #3078 POS Currency Entry not working, #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After a good hint in the issue and quite a bit of trial and error I managed to replace the old implementation with a low level DOM-manipulation that works. I also refactored the code a bit, and changed it from Javascript to Typescript. I committed that separately in case that's a problem, though I also caught one or two possible bugs when adding the type annotations. |
alexlukas
changed the title
|
gonna go ahead and get this in, i'm not really a user of this feature but it seems like you are and this is working for you ( : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (if applicable): #3078
Explanation of Bugfix/Feature/Modification:
Replaced the implementation based on Ember components with a low level event handler registered directly on the inputs. Does not work so far - the correct value is determined, but setting it to the input element in the event handler is not enough.