Fixes broken CSS classes #3385
Merged
Fixes broken CSS classes #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appears that YNAB updated CSS variable names resolves toolkit-for-ynab#3382, toolkit-for-ynab#3383
This was referenced Feb 23, 2024
|
@YusefOuda Thanks for fixing this! I went to try out my new fix from #3359 and thought I broke something. I found the issue and got like half way through fixing and realized I hadn't pulled from main and 🪄 they were fixed! From my second pass it looks like you got them all, appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appears that YNAB updated CSS variable names from snake_case to camelCase. I did my best to update all of them and not break anything, but there were a ton of changes
GitHub Issue (if applicable): #3382, #3383
Explanation of Bugfix/Feature/Modification:
Fix outdated CSS classes