fix: ensure pacing rerendering when changing views #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasburguiere
force-pushed
the
main
branch
2 times, most recently
from
eefd134
to
3e97134
Compare
thomasburguiere
force-pushed
the
main
branch
from
3e97134
to
0a2d550
Compare
|
Hi @joshmadewell sorry to bother you, but would it be possible to have an ETA regarding when this PR could be reviewed ? |
joshmadewell
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (if applicable): #3390
Explanation of Bugfix/Feature/Modification:
This PR changes the logic used to determine when the Pacing feature should be re-rendered.
It ensures pacing gets re-rendered when needed when switching between YNAB views.