fix: stop using ember-view #3428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willpoorman
reviewed
Apr 13, 2024
| import { | ||
| getDeemphasizedCategories, | ||
| pacingForCategory, | ||
| setDeemphasizedCategories, | ||
| } from 'toolkit/extension/utils/pacing'; | ||
| import { formatCurrency } from 'toolkit/extension/utils/currency'; | ||
| import { l10n } from 'toolkit/extension/utils/toolkit'; | ||
| import { budgetRowInChangesSet } from 'toolkit/extension/features/budget/utils'; | ||
| import { | ||
| budgetRowInChangesSet, |
There was a problem hiding this comment.
@joshmadewell, it appears this function was removed from the utils, but is still being imported on this line and used on line 61. I noticed it when I ran yarn build:development in the repo:
WARNING in ./src/extension/features/budget/pacing/index.js 48:8-29
export 'budgetRowInChangesSet' (imported as 'budgetRowInChangesSet') was not found in 'toolkit/extension/features/budget/utils' (possible exports: GOAL_TABLE_CELL_CLASSNAME, ensureGoalColumn, getBudgetMonthDisplayMasterCategory, getBudgetMonthDisplaySubCategory)
@ ./src/extension/features/index.ts 73:0-41 301:5-11 474:4-10
@ ./src/extension/ynab-toolkit.tsx 2:0-54 98:20-36
@ ./src/extension/index.js 1:0-45 2:22-33
Was that function intentionally removed and thus it should stop being used here? Or should the function be restored so that it can be used here?
There was a problem hiding this comment.
Should Pacing's observe method be updated to match the updated DisplayTargetGoalAmount's observe method?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Bugfix/Feature/Modification:
remove the
getEmberViewutility, use other methods to get the underlying data we need