Fix income vs expense #3443
Merged
Fix income vs expense #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmadewell
approved these changes
May 1, 2024
HelloThisIsFlo
pushed a commit
to HelloThisIsFlo/toolkit-for-ynab
that referenced
this pull request
May 6, 2024
* Fix pacing feature * Fix income vs expense report on datasets of uneven length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (if applicable): #3425
Explanation of Bugfix/Feature/Modification:
I missed setting correct initial value for
monthlyTotalsin my recent PR where I migrated reports to TypeScript. This was causing exception if expenses and incomes were of different length (e.g. there were no expenses in one month, only income). This is now fixed.I also removed a couple of TODOs (which were intended to be my working notes, rather than be actually pushed 馃槄). This PR is based on #3437, as those PR fixes issue which polluted console too much and was making debugging a bit miserable.
A HUGE THANKS goes to @willpoorman for helping with debugging this problem and actually figuring out what causes it.