Fix multiple categories search bars #3447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmadewell
approved these changes
May 1, 2024
joshmadewell
requested changes
May 1, 2024
joshmadewell
approved these changes
May 1, 2024
HelloThisIsFlo
pushed a commit
to HelloThisIsFlo/toolkit-for-ynab
that referenced
this pull request
May 6, 2024
* Fix pacing feature * Fix 'Search categories' input appearing multiple times * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (if applicable): #3445 #3444
Explanation of Bugfix/Feature/Modification:
It turned out, toolkit script might be injected multiple times in the page. Not sure why and how, but for me it happened only first time I open YNAB after installing the extension. And this apparently messed up with some features, as debouncing didn't work as expected. I added simple check to ensure toolkit isn't initiated second time