Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider images that are currently nominated for deletion as patrolled #4

Open
nicolas-raoul opened this issue Nov 15, 2016 · 7 comments

Comments

@nicolas-raoul
Copy link

They have obviously been seen by an experienced user already, so they should be considered as patrolled.

@Steinsplitter
Copy link
Member

Files seen by an experienced users are marked as patrolled.

@nicolas-raoul
Copy link
Author

If a file has already been nominated for deletion, showing it in newbie-uploads is not useful, right?

Let's consider a scenario where among the 50 first images, 10 are clearly bad. I open the 10 clearly bad images, and discover that all 10 have already been nominated for deletion. In that scenario, I wasted my time checking these 10 images. The tool should have hidden these already nominated images, so that I can focus on the other images. Am I being clearer?

@zhuyifei1999 zhuyifei1999 reopened this Nov 16, 2016
@zhuyifei1999 zhuyifei1999 changed the title Consider as patrolled images that are currently nominated for deletion Consider images that are currently nominated for deletion as patrolled Nov 16, 2016
@zhuyifei1999
Copy link
Member

@Steinsplitter WHERE rc_cur_id NOT IN (SELECT tl_from FROM templatelinks WHERE tl_namespace = 10 AND tl_title IN (<speedy template>, <dr template>, <no source/license/permission templates>) LIMIT 1)?

@Steinsplitter
Copy link
Member

@zhuyifei1999: The problem is that it will make the tool slower.

@nicolas-raoul
Copy link
Author

How much time does the query for 30 images take before/after this addition, on average?

#13 would make newbie-uploads feel much faster, so implementing both #4 and #13 at the same time would make it both faster and more useful.

@Steinsplitter
Copy link
Member

you'r welcome to submit pull requests :-)

@nicolas-raoul
Copy link
Author

I would love to participate in the coding!
I am already developing for so many open source projects, though (mostly Java/C# rather than web/PHP), so I thought I would just write down some ideas, hoping that some volunteers would jump in :-)

Similar possible enhancement: Hide deleted files. No need to patrol them, obviously. I don't know whether that is easy to detect via SQL, but they seem to appear like this:
screenshot from 2016-11-17 15-08-08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants